adafruit / adafruit/Adafruit_CircuitPython_IL0373

`__init__()` arguments are not Pin objects

Open
#25 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
10
PR merge metrics
No merged PRs in 30d

Description

We recently changed argument names for initializing the ESP32SPI library to use the suffix _dio rather than _pin because the arguments need to be instantiated DigitalInOut objects, not microcontroller.Pin objects.

See: adafruit/Adafruit_CircuitPython_ESP32SPI#121

This library uses the same *_pin names for it's arguments which are also expected to the DigitalInOuts rather than Pins.

I think we'll want to change the names here and any other libraries that have _pin to keep things consistent across libraries.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the IL0373 library's __init__() arguments that use the *_pin naming and compare their expected DigitalInOut values with the referenced ESP32SPI change. Identify all affected names and callers, then verify that the renamed arguments consistently represent DigitalInOut objects across the library.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
embedded-iot
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.