adafruit / adafruit/Adafruit_CircuitPython_BLE_BroadcastNet

Possible type bugs for wire types in AdafruitSensorMeasurement

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
14
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Comparing https://github.com/adafruit/Adafruit_CircuitPython_BLE_BroadcastNet/blob/c6328d5c7edf8a99ff719c3b1798cb4111bab397/adafruit_ble_broadcastnet.py#L129 with https://circuitpython.readthedocs.io/en/5.0.x/docs/design_guide.html#sensor-properties-and-units there are a few type mismatches:

- `color` - `f` vs int (32bit is used in `AdafruitColor()`)
- `duty_cycle` - `f` vs int (16bit int?)
- `frequency` - `f` vs int
- `value` - `f` vs a "union" of int (16 bit) /bool

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at adafruit_ble_broadcastnet.py around line 129 and compare the wire types for color, duty_cycle, frequency, and value with the CircuitPython sensor properties and units documentation linked in the issue. Confirm the documented and encoded types agree for all four fields; done means the mismatches are resolved and the relevant values remain compatible with the broadcast format.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.