actualbudget / actualbudget/actual

[Bug]: Custom themes custom CSS leftovers when selecting stock theme

未关闭
#8,896 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
help wanted
主要语言
TypeScript
星标
28.7k
派生
3k
平均合并
2 天 11 小时
30 天内合并 PR
65

描述

### What happened?

When selecting a custom theme and then adding custom CSS, I would expect that reverting to a "stock" theme would ignore the custom CSS that was added when using a custom theme (or maybe was the feature designed to also be able to customize stock themes?). Nonetheless, there is a visual glitch when selecting the "System Default" option from the theme selector after applying custom CSS. The "Custom CSS is active" button/url remains visible when reverting to a stock theme. Furthermore, the custom CSS gets applied over the stock theme.

### How can we reproduce the issue?

I was able to reproduce the issue in the demo version of Actual following the steps below :

1. Select a custom theme and add custom CSS
2. Revert to any of the stock themes selection
3. See the "Custom CSS is active" button still being present.
4. When reverting to the "System Default" theme selection, the "Custom CSS is active" button is stacked below the "Light" theme dropdown selection.

Image

### Where are you hosting Actual?

Docker

### What browsers are you seeing the problem on?

Chrome

### Operating System

Mac OSX

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。