actualbudget / actualbudget/actual

[Bug]: SimpleFIN error not surfaced to UI

未关闭
#6,426 4 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
bank sync
主要语言
TypeScript
星标
28.7k
派生
3k
平均合并
2 天 11 小时
30 天内合并 PR
65

描述

### Verified issue does not already exist?

- [x] I have searched and found no existing issue

### What happened?

I recently set up an American Express account through SimpleFIN. The original bank sync of the account seemed to work just fine. However, all subsequent sync attempts are throwing exceptions on the client side JS. This seems to be the offending block in sync.ts:

Image

As you can see, `download` ends up undefined because the account ID is not actually found in the `res` object. This leads to a thrown exception at the highlighted line since it tries to access the `error_code` property on `undefined`.

The result of this is I can't sync this account at all, and also the "sync all" button errors out at this account so I need to sync all of my other accounts manually.

### How can we reproduce the issue?

No clue, I'm guessing it's either a problem with the SimpleFIN data coming back or just a logic bug in the JS. There _should_ be new transactions coming in from this account, though. Let me know if I can give you anything else to help debug.

### Where are you hosting Actual?

Docker

### What browsers are you seeing the problem on?

Chrome

### Operating System

Windows 11

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。