actualbudget / actualbudget/actual

[Bug]: [APP CRASH] Hide reconciled transactions can crash app and makes running balance noncontiguous. [solutions included]

オープン
#6,073 コメント 1 件 リアクション 1 件 担当者 0 名 GitHub で見る
transactions user interface
主要言語
TypeScript
スター
28.7k
フォーク
3k
平均マージ
2日 11時間
マージ済み PR(30日)
65

説明

### Verified issue does not already exist?

- [x] I have searched and found no existing issue

### What happened?

This issue was partially fixed in closed issue #2703 however there are more issues related to this that could be easily solved. I have solutions for both of the issues below:

1.) Running balance not contiguous when uncleared transactions older than some reconciled transactions. This was mentioned in the 2703 PR thread and was considered an acceptable limitation.

2.) **[Major Breaking Bug]** - If transactions are hidden then a new sorting order is chosen, it completely crashes the app or browser upon showing reconciled transactions again

### How can we reproduce the issue?

### Running balance not contiguous when uncleared transactions older than some reconciled transactions.
**To reproduce:**
Have some reconciled transactions dated newer than uncleared / cleared transactions when hiding reconciled. This will cause the shown running balance to no longer match what is shown in the register. While the balance is technically accurate based on transaction entry date, it is not accurate to what is actually in the account as uncleared transactions have not been verified as having shown at the bank. This can be key in finding errors in data entry.

**Example of balance not matching displayed transactions:**
Before hiding reconciled:
Image

After hiding reconciled:
Image

To solve this issue the process after clicking "Hide reconciled transactions" should be:
1.) Change sorting to "cleared" - This will move all reconciled transactions to the bottom of the list, followed by cleared, then the uncleared transactions are sorted by date.
2.) Calculate Running Balance.
3.) Stop rendering reconciled transactions.

In making these changes, it would also be great if someone could make the running balance field visible on the register when sorting by "cleared" as that is my preferred sorting. When I'm looking at my Running Balance, I prefer to be able to see my actual current cleared balance as well as my "available balance" based on unlcleared transactions. (I know this value is visible in the balance information as cleared balance but I like to have the timeline view that the running balance gives.)

### **[Major Breaking Bug]** - If transactions are hidden then a new sorting order is chosen, it completely breaks the running balance and can completely crash the app.

To reproduce:
1.) Hide reconciled transactions
2.) Change sorting
3.) Click Show Reconciled Transactions
4.) Entire app completely breaks requiring it to be closed and re-opened or browser refreshed (If browser isn't frozen as well as that happens too)

To solve this issue:
Clicking "Remove all sorting" before clicking "Show reconciled transactions" completely mitigates this issue so just make clicking "Show Reconciled Transactions" run that routine first in all situations and this is fixed

You can see in this example video, after showing transactions, they don't show up and no matter where I click nothing happens until Firefox lets me stop the page. Even then it is unusable until reloaded. The same happens in the desktop app however it must be completely closed and re-opened to use again.

https://github.com/user-attachments/assets/677b1c4f-bd33-4824-b64f-816fa4ad89a3

.

### Where are you hosting Actual?

Docker

### What browsers are you seeing the problem on?

Firefox, Desktop App (Electron), Chrome, Microsoft Edge

### Operating System

Windows 11

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。