acts-project / acts-project/acts

`Grid` and `MultiAxis` related naming

Abierto
#5,601 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Stale
Lenguaje dominante
C++
Estrellas
131
Forks
276
Merge medio
3 d 13 h
PR fusionados (30 d)
112

Descripción

While working on the `MultiAxis` implementation I stumbled over a few potentially suboptimal names

1. `global bin` and `local bins`
- `bin` is actually an `index` - we could call it that way
- `global` / `local` is a loaded term in ACTS and usually refers to different coordinate systems
- my suggestion here would be something like `flat index` or `linear index` and `multi index`
2. for `Axis` we use `getX` while for `Grid` we use `x`
3. `lower left edge` / `upper right edge`
- I believe this should rather be `corner`
4. `position` vs `point`

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.