acts-project / acts-project/acts

Rework digitization for Gen3 geometry

オープン
#5,401 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
Stale
主要言語
C++
スター
131
フォーク
276
平均マージ
3日 13時間
マージ済み PR(30日)
112

説明

The workflow with the Geometry-Id-Hook that assigns the extra bit for different rings in the ODD won't work straight forward with Gen3. In that context, a more general rework of the digitzation could be done, which also would improve several other aspects.

Goals are:
- Decouple the digi config from the geometry hierarchy, make it stable against changes in geometry ID numbering
- Try to avoid redundant information on surface size in the config file
- Future: Allow to use encoded information on digitzation from DD4Hep etc.

Proposed steps for ODD:
- [ ] Encode subsystem information in the ODD detector element / DD4hep detector element (walk DD4hep tree on construction)
- [ ] In digitization: Use `dynamic_cast` (or a design interface) to retrieve subsystem
- [ ] Only encode pitch of subsystems in json file, located in ODD repository (independent of geo id)
- [ ] Keep compatibility with current workflow to ensure correctness

@andiwand @paulgessinger

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。