acts-project / acts-project/acts

Potential FPE suppression/hiding in `GsfUtils.hpp`

Ouverte
#4,031 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Stale
Langage dominant
C++
Étoiles
131
Forks
276
Merge moyen
3 j 13 h
PR mergées (30 j)
112

Description

https://github.com/acts-project/acts/blob/c0e65bc9ee2d99eca81a7098bd43653e071e3200/Core/include/Acts/TrackFitting/detail/GsfUtils.hpp#L197-L200

This looks like silent FPE treatment which might either come from the `chi2` being too large pushing `detR` to `inf` or caused by `detR` being negative in case the covariance is already broken. Both should in principle not happen but we protect against it and silence any occurrence right now.

In https://github.com/acts-project/acts/pull/3449 I observed an FPE at https://github.com/acts-project/acts/blob/c0e65bc9ee2d99eca81a7098bd43653e071e3200/Core/include/Acts/TrackFitting/detail/GsfUtils.hpp#L195 which indicates that `detR` is negative and this should only happen if at least one of the covariances is broken.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.