acts-project / acts-project/acts

test: some bounding box test cases fail on macOS ci

Offen
#3,847 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Impact - Minor Stale
Vorherrschende Sprache
C++
Sterne
131
Forks
276
Ø Merge
3 T. 13 Std.
Gemergte PRs (30 T.)
112

Beschreibung

Many cases were disabled in `Tests/UnitTests/Core/Utilities/BoundingBoxTest.cpp` because of `fails with double precision`. After rechecking all tests in
- https://github.com/acts-project/acts/pull/3829/files
we enabled most of the cases, but some are still failing only on the macOS ci.

The disabled tests are:
```
// upper bound is exclusive - temporarily removed, fails macOS ci
// ray = {{-2, 1}, {1, 0}};
// BOOST_CHECK(!bb.intersect(ray));

// upper bound is exclusive - temporarily removed, fails macOS ci
// ray = {{2, 1}, {-1, 0}};
// BOOST_CHECK(!bb.intersect(ray));

// right on slab - temporarily removed, fails macOS ci
// ray3 = {{0, 1, -2}, {0, 0, 1}};
// BOOST_CHECK(!bb3.intersect(ray3));
```
The reason is not clear yet and should be investigated.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.