acts-project / acts-project/acts

Potential Dangling Pointers in `createTree` Function

Open
#3,814 1 comment 0 reactions 1 assignee Claimed by @CarloVarni View on GitHub
Stale
Dominant language
C++
Stars
131
Forks
276
Avg merge
3d 13h
Merged PRs (30d)
112

Description

As discussed in [PR #3729](https://github.com/acts-project/acts/pull/3729#discussion_r1829372523), there is a potential issue with storing addresses of loop variables in the `createTree` function, which could lead to dangling pointers if `spacePoints` gets modified or goes out of scope. Addressing this issue would involve major changes in several parts of the ACTS project and is out of scope for PR #3729. This issue is opened to track the work required to resolve this in a future PR.\n\nRequester: @CarloVarni

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.