acts-project / acts-project/acts

bug: some dependencies in setup script wrong

Abierto
#3,014 6 comentarios 0 reacciones 1 asignado Reclamado por @andiwand Ver en GitHub
Bug Impact - Minor Stale
Lenguaje dominante
C++
Estrellas
131
Forks
276
Merge medio
3 d 13 h
PR fusionados (30 d)
112

Descripción

Trying out the great idea from #2926, I noticed, that some of the dependencies have the wrong path.

## Issue

In `/this_acts_withdeps.sh` I get the following code:

```shell
if [[ -d "/opt/hep/root/6.30.02/cmake" ]]; then
. /opt/hep/root/6.30.02/bin/thisroot.sh
fi
if [[ -d "/opt/hep/geant4/11.2.0/lib/cmake/Geant4" ]]; then
. /../../bin/geant4.sh
fi
if [[ -d "/opt/hep/dd4hep/01-27-02/cmake" ]]; then
. /../bin/thisdd4hep.sh
fi
```

The setup for root points to the correct file, Geant4 and DD4hep have a broken path.

## Possible solution

The solution here would work for my local setup:
https://github.com/AJPfleger/acts/tree/fix-deps

it basically changes in https://github.com/acts-project/acts/blob/main/cmake/setup_withdeps.sh.in
```shell
if [[ -d "@Geant4_DIR@" ]]; then
. @Geant4_INCLUDE_DIR@/../../bin/geant4.sh
fi
if [[ -d "@DD4hep_DIR@" ]]; then
. @DD4hep_INCLUDE_DIRS@/../bin/thisdd4hep.sh
fi
```
to
```shell
if [[ -d "@Geant4_DIR@" ]]; then
. @Geant4_DIR@/../../../bin/geant4.sh
fi
if [[ -d "@DD4hep_DIR@" ]]; then
. @DD4hep_DIR@/../bin/thisdd4hep.sh
fi
```
Let's check with different setups.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.