acts-project / acts-project/acts

`SurfaceReached` aborter is messing with the step size

Open
#2,738 1 comment 0 reactions 0 assignees View on GitHub
Stale
Dominant language
C++
Stars
131
Forks
276
Avg merge
3d 13h
Merged PRs (30d)
112

Description

The `SurfaceReached` is doing basically a navigation procedure in parallel to the `Navigator` and the one which sets the smallest step size wins. This seems error prune to me and like a mixture of concepts. IMO only the navigator should set the step size and the aborter can check if we are on the surface or not.

This could be realized by adding the target surface as an external surface to the navigator state.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.