acts-project / acts-project/acts
[Feature Request] Reference surface for tracking algorithm is hardcoded to be at origin
- Linguagem predominante
- C++
- Estrelas
- 131
- Forks
- 276
- Merge médio
- 3d 13h
- PRs com merge (30d)
- 112
Descrição
Hi,
I noticed the following while going through the Python example scripts in Acts:
When using the Kalman Filter truth tracking from `https://github.com/acts-project/acts/blob/main/Examples/Python/python/acts/examples/reconstruction.py` I got the following error:
` ResPlotTool ERROR Global to local transformation did not succeed.`
Apparently this happens, because the starting vertex for my particle gun is not located at the origin. The reference surface for the tracking algorithm seems to be hardcoded in `https://github.com/acts-project/acts/blob/main/Examples/Algorithms/TrackFitting/src/TrackFittingAlgorithm.cpp#L88`
Many thanks to @andiwand for helping me to understand what the underlying problem was here.
I feel like this could become restrictive in case the fitting algorithm is used for experiments with non collider geometries. I was indeed able to remove the above error by adapting the corresponding reference surface.
It is probably possible to mostly circumvent this by either also hardcoding this if necessary or using custom global coordinate transformations for affected geometries. The cleanest option would probably be to pass the reference surface from a higher level down to the tracking algorithm. Even though I must admit, that I have no idea how complicated this implementation would be.
However I thought it might be a good occasion to properly document this in case someone else might have the same problem in the future.
Guia de contribuição
Avaliação
Esta issue ainda não foi avaliada.