acts-project / acts-project/acts

Bug: not all tracks have fittedMomentum

Open
#2,364 2 comments 0 reactions 0 assignees View on GitHub
Bug Stale
Dominant language
C++
Stars
131
Forks
276
Avg merge
3d 13h
Merged PRs (30d)
112

Description

In PR #2359 I make it optional for the `TrackAtVertex` object to have a `fittedMomentum` (i.e., the updated momentum from the vertex fit). Previously, the latter was always initialized to the momentum before the vertex fit.

When I made this transition, I realized that some tracks never obtain a `fittedMomentum` variable even though they contribute to the vertex fit. I believe this should not be the case.

As a preliminary measure, I added an `ACTS_WARNING` to the `VertexPerformanceWriter.`

![image](https://github.com/acts-project/acts/assets/72298366/a3023d7d-528d-443b-885a-680b98fd50ac)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.