acts-project / acts-project/acts

Cut tube segment dd4hep conversion tests

Open
#1,146 10 comments 0 reactions 2 assignees Claimed by @Corentin-Allaire View on GitHub
Improvement Needs Decision Stale
Dominant language
C++
Stars
131
Forks
276
Avg merge
3d 13h
Merged PRs (30d)
112

Description

Proposed labels: Improvement, Needs Discussion

Proposed next steps on cut tube support that touch the Acts code base:

1) Extend TGeoTubeConversionTests.cpp with a TGeoCtub (like done [here](https://github.com/acts-project/acts/blob/main/Tests/UnitTests/Plugins/TGeo/TGeoTubeConversionTests.cpp#L64) for TGeoTubeSeg), this test will fail until support below is added,

a) Extend Acts::TGeoSurfaceConverter::cylinderComponents (like done [here](https://github.com/acts-project/acts/blob/main/Plugins/TGeo/src/TGeoSurfaceConverter.cpp#L88)
for TGeoTubeSeg) to support TGeoCtub (TGeoCtub inherits TGeoTubeSeg inherits TGeoTube, so
the same strategy taken there simply extends), and similarly extends
Acts::TGeoSurfaceConverter::discComponents (like [here](https://github.com/acts-project/acts/blob/main/Plugins/TGeo/src/TGeoSurfaceConverter.cpp#L240))
The test above should now succeed.

2) extend Acts::DD4hepLayerBuilder::endcapLayers (like done [here](https://github.com/acts-project/acts/blob/main/Plugins/DD4hep/src/DD4hepLayerBuilder.cpp#L90) for TGeoTubeSeg) and Acts::DD4hepLayerBuilder::centralLayers (like done [here](https://github.com/acts-project/acts/blob/main/Plugins/DD4hep/src/DD4hepLayerBuilder.cpp#L238) for TGeoTubeSeg) to support TGeoCtub.

3) Are there any DD4hep unit tests that should be updated to test?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.