actix / actix/actix-web

Make a decision whether we should enable `TCP_NODELAY` by default or not

Aperta
#3,917 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
24.8k
Fork
1.9k
Merge medio
23h 10m
PR unite (30g)
26

Descrizione

> The problem here should be related to Nagle’s algorithm, i.e. the `TCP_NODELAY` option.
> On Node.js, it's enabled by default: https://nodejs.org/api/http.html#httpcreateserveroptions-requestlistener
> On actix-web (actix-http), it's disabled by default (no config).
> I've tested on your benchmark and confirmed enabling it via `actix_tls` resolved the latency difference.
> Maybe we should make it enable by default, but it's a behavior change and should happen on major release.
> For now, I'm going to add a helper method to enable it easily.

_Originally posted by @JohnTitor in [#3841](https://github.com/actix/actix-web/issues/3841#issuecomment-3883169095)_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.