actix / actix/actix-extras

Session state can't be read in stream of streaming response

Open
#290 0 comments 0 reactions 0 assignees View on GitHub
A-session C-improvement
Dominant language
Rust
Stars
889
Forks
224
Avg merge
9h 37m
Merged PRs (30d)
20

Description

## Expected Behavior

https://github.com/mohe2015/actix-extras-285/blob/main/src/main.rs
If I didn't mess anything up in a perfect world I would expect the set-broken to either not compile or to panic. Also I would expect the get-broken to either work or to not compile or to panic.

## Current Behavior

To my understanding currently reading the session in a stream silently doesn't contain the data of the session. It is clear though that setting the data in the stream is not supposed to work as the headers have already been sent (potentially). Currently it silently discards that session data.

## Possible Solution

I think the best thing would be either prevent this to compile (don't know if this is possible) and then force the user to retrieve that data outside of the stream or to allow reading the data but panic on setting the data. Don't know how this works implementation wise though.

## Steps to Reproduce (for bugs)

1. Run https://github.com/mohe2015/actix-extras-285
2. Follow the steps in the code: https://github.com/mohe2015/actix-extras-285/blob/4ff4b71d113423d604875920a54bff6c6ec31fc8/src/main.rs#L54
3. See that the broken endpoints don't return the session or don't change the session.

## Context

I was wondering where my session data went when reading it. Debugging this was really weird because first I thought CORS is at fault.

## Your Environment

* Rust Version (I.e, output of `rustc -V`): rustc 1.65.0-nightly (750bd1a7f 2022-09-14)
* Actix-* crate(s) Version: actix-web v4.2.1, actix-session v0.7.2

XREF https://github.com/actix/actix-extras/pull/285 (docs may need adjustment then)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.