actions / actions/toolkit

Inputs with `-` are hard to test due to shells not supporting env variables with `-` in the name

Open
#629 5 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core enhancement
Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

I'm trying to test my action and according to the code the input variables seem to be injected through input variables. See
https://github.com/actions/toolkit/blob/e7eb2c741847a05686a1b8df93dea4b244640b17/packages/core/src/core.ts#L86

Given the GITHUB_TOKEN is provided via with:

with:
  repo-token: ...

This would result in INPUT_REPO-TOKEN as an environment variable. Which is invalid.

The following is therefore not possible:

INPUT_REPO-TOKEN=$GITHUB_TOKEN ts-node src/main.ts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/core/src/core.ts at the referenced line around 86 and compare how with: repo-token becomes an environment variable. Reproduce the issue using the shown INPUT_REPO-TOKEN=$GITHUB_TOKEN ts-node src/main.ts command. Done means inputs containing - can be tested through the supported environment-variable path.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.