actions / actions/toolkit

different cache file names needed for zstd with or without --long?

Open
#542 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug cache
Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

To be honest, I didn't try this, just something that came to my mind when having a short look at the sources.
So if this is not an issue actually, just close this.
But as far as the man page of zstd says, if you use --long with a value lager than 27 on compression, you also have to specify it on decompression.

But following the current logic, if you create a cache on a system with new zstd where --long is supported and then try to restore the cache on a system with old zstd where --long is not supported, the decompression will probably fail.
So I think a separate file name for zstd with --long is necessary.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing the toolkit's cache naming and zstd compression/decompression logic, then check the zstd man page and reproduce the described mismatch between --long and older zstd versions. Done means confirming whether the failure occurs and documenting or implementing the required cache-name separation if it does.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.