actions / actions/toolkit

tool-cache should accept URL for download

Open
#534 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

It would be nice if the tool-cache would support giving download URLs as URL objects.
Currently you only get

The "url" argument must be of type string. Received type object
Waiting 11 seconds before trying again
The "url" argument must be of type string. Received type object
Waiting 12 seconds before trying again
##[error]The "url" argument must be of type string. Received type object

Besides that retry does not make much sense in this case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tool-cache download entry point and the code that validates the "url" argument. Check how URL objects are currently handled and where retries are triggered; done means URL objects are accepted for downloads and the type error does not cause pointless retries.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.