actions / actions/toolkit

Tool-Cache getManifestFromRepo should use default branch or require a branch

Open
#529 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement tool-cache
Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

Currently, the tool-cache's getManifestFromRepo defaults to the master branch if no branch is specified. Not every repo uses that as the default branch, we should try defaulting to the default branch, or just make users have to specify which branch to use.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating tool-cache's getManifestFromRepo and inspect how it chooses a branch when none is supplied. Check existing tests around manifest retrieval and determine whether the intended behavior is using the repository's default branch or requiring an explicit branch. Done means the non-master default-branch case is handled and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.