downloadTool should confirm file length matches `Content-length` header
Open
Nobody has claimed this yet.
enhancement
tool-cache
- Dominant language
- TypeScript
- Stars
- 5.9k
- Forks
- 1.8k
- PR merge metrics
- No merged PRs in 30d
Description
We should verify the response stream size matches the Content-length header. Node doesn't check. Better yet, verify the written file length to make sure we're not losing anything end-to-end.
Debug tracing the Content-length header may also be useful.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TypeScript implementation and entry point for downloadTool, then trace the response stream through the written file. Review any existing downloadTool tests before changing behavior. Done means the response and final file lengths are checked against Content-length, with useful tracing for that header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100