actions / actions/toolkit

additional debug in _findMatch for osVersion & platform_version needed to make sense of earlier debug statements

Open
#1,813 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
additional debug in _findMatch for osVersion & platform_version is needed to make sense of earlier debug statements

Currently no debug displays the osVersion identified and the expected platform_version. This leads to the debug for architecture display valid comparisons like #[debug]x86===x86 && linux===linux but no subsequent reason for the osVersion check to work. The present state is confusing

To Reproduce
Run actions/setup-python on a platform that isn't support by the action (e.g. RHEL).

Expected behavior
debug needs to display versions for clarity.

Screenshots

  ##[debug]check 3.10.14 satisfies 3.10
  ##[debug]x64===x64 && darwin===linux
  ##[debug]x64===x64 && linux===linux
  ##[debug]arm64===x64 && linux===linux
  ##[debug]x64===x64 && linux===linux
  ##[debug]arm64===x64 && linux===linux
  ##[debug]x64===x64 && linux===linux
  ##[debug]check 3.10.13 satisfies 3.10

Despite successful matches, no info as to why those failed.

Desktop (please complete the following information):
All platforms.

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the TypeScript sources for _findMatch and inspect the existing architecture and platform debug statements. Reproduce the lookup on an unsupported platform such as RHEL; done means the debug output identifies the detected osVersion and expected platform_version so failed matches are explainable.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.