Links created for annotations are (sometimes) broken
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.9k
- Forks
- 1.8k
- PR merge metrics
- No merged PRs in 30d
Description
I'm not sure this issue is related to this repo. Please forward to the right place, if link generation is not dealt with here.
Describe the bug
GHA provides the great feature of linking annotations shown on a build's summary page to the corresponding line in the log.
However, in this build the generated links are broken: they refer to step:16 although the build only comprises 9 steps. Replacing the step number with the correct one (step:5) fixes this.
Looks like the calculation of the step reference is broken. I wasn't able to reproduce the issue in a smaller scenario.
To Reproduce
- Check build https://github.com/rhaschke/ros-o-builder/actions/runs/5956785236
- The link https://github.com/rhaschke/ros-o-builder/actions/runs/5956785236/job/16168574163#step:16:5085 generated for the error
bloom-generate failed for rosbuildis broken.
Expected behavior
The link should be: https://github.com/rhaschke/ros-o-builder/actions/runs/5956785236/job/16168574163#step:5:5085
Desktop (please complete the following information):
Browser: Google Chrome, version 116.0.5845.110 (Official Build
Additional context
Clicking on a line number in the log within the browser, shows the correct link in the navigation field.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the linked GitHub Actions build and compare the generated annotation URL using step:16 with the expected step:5 URL. Trace the toolkit's annotation link generation from that observed discrepancy; done means the affected annotation links target the correct log step and the behavior is covered by a regression check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100