actions / actions/toolkit

weak hashing functions MD5

Open
#1,304 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

Describe the enhancement

MD5 is a weak hash function and should not be used for security purposes. It is also not supported by the hash function in Azure Logic Apps. It would be nice to have a SHA256 hash function available.

Code Snippet
use sha256 instead of md5

https://github.com/actions/toolkit/blob/06c3c38ef2b06460057795826f7977cec630099f/packages/artifact/src/internal/utils.ts#L311

Additional information
None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at packages/artifact/src/internal/utils.ts around line 311 and inspect how the current MD5 hash is used. Replace that hashing choice with SHA256 as requested, then verify the artifact utility still produces the expected hash behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.