actions / actions/toolkit

Add debug log for platform_version check

Open
#1,130 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.9k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

I was running an actions/setup-python in an unsupported container and was baffled by some of the debug logging.

[Publish latest development version/pdf]   💬  ::debug::check 3.9.13 satisfies 3.9
[Publish latest development version/pdf]   💬  ::debug::x64===x64 && darwin===linux
[Publish latest development version/pdf]   💬  ::debug::x64===x64 && linux===linux
[Publish latest development version/pdf]   💬  ::debug::x64===x64 && linux===linux
[Publish latest development version/pdf]   💬  ::debug::x64===x64 && linux===linux
[Publish latest development version/pdf]   💬  ::debug::x64===x64 && win32===linux
[Publish latest development version/pdf]   💬  ::debug::x86===x64 && win32===linux

The logging very helpfully logs which versions it is checking
https://github.com/actions/toolkit/blob/e1a7863be630ea22c506f848a0762cb17e0534f8/packages/tool-cache/src/manifest.ts#L77-L99

But skips this logging in for the platform_version check, which I fully expect to be failing in my case.
https://github.com/actions/toolkit/blob/e1a7863be630ea22c506f848a0762cb17e0534f8/packages/tool-cache/src/manifest.ts#L91


I'd be willing to take this up myself, if this is indeed considered a bug

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in packages/tool-cache/src/manifest.ts, reading the debug logging around lines 77-99 and the platform_version check at line 91. Confirm how the existing version checks are logged, then make the platform_version comparison equally visible and verify that debug output identifies the versions being checked.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.