Since nvm v0.40.0 .nvmrc may contain comments
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5k
- Forks
- 1.7k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 2
Description
Description:
Since nvm v0.40.0 .nvmrc may contain comments.
[New] allow .nvmrc files to support comments
Action version:
v4.0.3
Repro steps:
- uses: actions/setup-node@v4.0.3
with:
node-version-file: .nvmrc
.nvmrc
# comment
20.16.0
Expected behavior:
.nvmrc files with comments are supported.
Actual behavior:
I have not verified it yet.
If it works already than this issue should at least add another test to the test suite.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the node-version-file input reads .nvmrc files, then reproduce the issue with the comment-and-version example in the report. Check whether comments are already handled and add or update a test in the existing test suite so the expected behavior is explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100