`The property '...' is set to ... which is out of range` is very unhelpful
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.3k
- Forks
- 1.4k
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 24
Description
Test case:
https://github.com/check-spelling-sandbox/upgraded-garbanzo-vigilant-journey/commit/91674afb28ffbd9bed25f160573878ccf554201e
Results:
https://github.com/check-spelling-sandbox/upgraded-garbanzo-vigilant-journey/actions/runs/22208910261
Annotations
2 errors
test
The property 'line' is set to 2 which is out of range
test
Unable to process command '::add-matcher::/home/runner/work/upgraded-garbanzo-vigilant-journey/upgraded-garbanzo-vigilant-journey/a.json' successfully.
Notes:
- It'd be helpful if the error message reported a file name and line number (preferably as an annotation, this happens for unhappy workflows)
- It'd be helpful if the problem matcher complained that the
regexpfield was not present - If you're going to complain about fields, it's best to complain in numerical sort order (
1before2) instead of alphabetical key order (linebeforemessage) - I don't understand why failure to process a problem matcher is deemed as fatal. Problem matchers are merely aids to help people interpret logs, they aren't mission critical. What's critical is that a workflow run to completion.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Runner.Worker/IssueMatcher.cs at the linked line and reproduce the behavior with the linked check-spelling commit and workflow run. Review the four requested improvements: more useful file and line diagnostics, reporting a missing regexp, numerical field ordering, and whether matcher failures should be fatal. Done means the resulting behavior addresses the agreed scope and the linked case no longer produces the unhelpful annotation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, github-actions
- Domain
- ci-cd, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100