Log "Kill entire process tree" does not match actual behavior
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.3k
- Forks
- 1.4k
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 24
Description
I have no experience with .NET, so I apologize if I am misunderstanding and this is not a bug
Describe the bug
The log "Kill entire process tree..."
https://github.com/actions/runner/blob/3f28dd845f5665426c4df81f2ef230d1cb1dd2da/src/Runner.Sdk/ProcessInvoker.cs#L463
does not match the actual behavior of the runner:
https://github.com/actions/runner/blob/3f28dd845f5665426c4df81f2ef230d1cb1dd2da/src/Runner.Sdk/ProcessInvoker.cs#L861
.Kill(), from my understanding, only kills that process. It does not kill children processes. To kill the entire process tree, use .Kill(true)
To Reproduce
Look at source code or run job with
steps:
- run: sleep 360
timeout-minutes: 1
and look at logs in ~/actions-runner/_diag/Worker_*.log
Expected behavior
Log says "Kill process" instead of "Kill entire process tree"
Runner Version and Platform
Version of your runner? v2.317.0
OS of the machine running the runner? Ubuntu 22.04
What's not working?
Log says "Kill entire process tree"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Runner.Sdk/ProcessInvoker.cs at the referenced lines around 463 and 861, then compare the logged message with the process operation used there. Reproduce with the provided timeout workflow on Ubuntu and inspect ~/actions-runner/diag/Worker*.log; done means the log accurately describes the observed process behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100