actions / actions/runner

Since GHES 3.6.3 actions/cache forces HTTPS only for getting cache

Open
#2,260 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
6.3k
Forks
1.4k
Avg merge
1d 16h
Merged PRs (30d)
24

Description

Runner Version and Platform

Runner=v2.299.1
GHES=v3.6.3

OS of the machine running the runner?
Linux

Describe the bug
Since GHES 3.6.3 actions/cache while getting cache artifact changing url to S3 with HTTP to HTTPS scheme

To Reproduce

Steps to reproduce the behavior:

  1. In GHES management console set S3 Artifact storage with HTTP scheme (for example: http://ceph-ph-lb:7480)
  2. Create cache with actions/cache in any workflow (this step saves cache as expected)
  3. Try to get artifact (at this step will be error because of wrong URL)
curl -H "Accept: application/vnd.github+json" -H "Authorization: Bearer $ACTIONS_RUNTIME_TOKEN" "$ACTIONS_CACHE_URL/_apis/artifactcache/cache?keys=$ARTIFACT_KEY&version=$ARTIFACT_VERSION"

{
  "scope":"refs/heads/feature/GitHub-actions",
  "cacheKey":"foo",
  "cacheVersion":"8b9a54e1d0c3a7f60f07959e4140cd1e9329a534ed286e9bcde9c8f06c789349",
  "creationTime":"2022-10-27T06:58:05Z",
  "archiveLocation":"https://ceph-ph-lb:7480/git-artifacts/actions-89961dc6eec8/6e672083c1b74b02b111c978ade16dae/5397433ef36b1410877600caf8946a3a?AWSAccessKeyId=**masked**&Expires=1666862469&Signature=**masked**%3D"
}

If you can see, service responsible for getting artifact artifactcache-api-server returns JSON with field archiveLocation with HTTPS scheme instead HTTP.

Expected behavior
Service artifactcache-api-server returns configured archiveLocation

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the cache lookup with the curl request and inspect the artifactcache-api-server handling of archiveLocation. Compare the configured HTTP S3 endpoint with the returned URL. Done means the service preserves the configured scheme and cache save and retrieval both work.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.