Debt: Handle escaping arguments more easily
Open
@ruvceskistefan is already working on this.
Since Aug 24, 2022.
enhancement
Runner Feature
- Dominant language
- C#
- Stars
- 6.3k
- Forks
- 1.4k
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 24
Description
Describe the bug
Currently, we do manual escaping in ProcessInvoker and its various overloads for arguments. We should move towards using the ArgumentList property which automatically handles escaping, as opposed to doing it by hand, which introduces opportunity of human error.
This is likely a large set of changes, we should put it behind a feature flag to ensure a safe rollout if we can.
See related prs in this area recently, and the source code for how we invoke process
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.