actions / actions/runner-container-hooks

Cannot set resource requirements for fs-init container in k8s-novolume mode

Open
#348 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
153
Forks
112
Avg merge
6m
Merged PRs (30d)
1

Description

When using a containerMode of 'kubernetes-novolume', the k8s-novolume hook script creates an init container called 'fs-init'. It is not currently possible to set the resource requests and limits for this container, which breaks deployment on infrastructures that require them to be declared.

Additionally it does not appear to be practical to override the entire 'fs-init' init container as its definition is conditional.

Ideally, it would be possible to override similar to the job container - by merging pod template definitions

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the k8s-novolume hook and the conditional fs-init container definition. Inspect how pod template definitions are handled for the job container, then determine how merging could expose fs-init resource requests and limits; done means those values can be overridden for deployments requiring them.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, typescript
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.