Add sanitization, validation, and basic tests for the `error_count` input parameter

Open
#172 2 comments 0 reactions 1 assignee View on GitHub

@GretaP is already working on this.

Since Jun 13, 2023.

Assessment

This issue has not been assessed yet.

Description

enhancement

Add sanitization, validation, and basic tests for the error_count input parameter.

Some possible rules:

  • ensure it is a finite number
  • ensure it is greater than 0
  • [optional] ensure it is less than the finalized timeout input parameter value (which may be adjusted to MAX_TIMEOUT, depending on the user's input) divided by the finalized reporting_interval
    • That is optional as it's unlikely that every single status check will report a temporary recoverable error 🤷🏻
    • Also, allowing the users to specify a number greater than that gives them the opportunity to allow as many errors as possible before timing out, which is OK if that's what they really want 🤷🏻

Similar to the a part of the changes made for timeout as shown in PR:

  • #170

See also:

  • #171
Dominant language
JavaScript
Stars
953
Forks
143
Avg merge
35m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from actions/deploy-pages

All issues in actions/deploy-pages

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.