actions / actions/actions-runner-controller
scaleSetLabels in gha-runner-scale-set is not reflecting in github runner
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 1.5k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 27
Description
Checks
- I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
- I am using charts that are officially provided
Controller Version
0.14.2
GitHub Enterprise Server
3.17.15
Deployment Method
Helm
Checks
- This isn't a question or user support case (For Q&A and community support, go to Discussions).
- I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
To Reproduce
1. Upgraded gha-runner-scale-set-controller to 0.14.2 through helm chart
2. Deployed gha-runner-scale-set with scaleSetLabels: [ubuntu24] and scaleSetLabels: ubuntu-scale-set for gha-runner-scale-set deployment
3. After deployment ~~runner~~ runner-scale-set showed up in the github with `ubuntu-scale-set` as label but `ubuntu24` was ignored.
Describe the bug
I am trying to migrate from existing RunnerDeployment using actions.summerwind.dev/v1alpha1 to gha-runner-scale-set.
In RunnerDeployment I have specified labels
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
name: gh-action-ubuntu
namespace: gh-action-runner
spec:
replicas: 1
....
labels:
- ubuntu24
I have specified scaleSetLabels: [ubuntu24] along with runnerScaleSetName: ubuntu-scale-set as override values for gha-runner-scale-set,
Corresponding runners runner-scale-sets are created in github and only runnerScaleSetName set as labels and labels passed to scaleSetLabels are ignored.
corresponding EphemeralRunnerSet created is
apiVersion: actions.github.com/v1alpha1
kind: EphemeralRunnerSet
metadata:
annotations:
actions.github.com/runner-group-name: Default
actions.github.com/runner-scale-set-name: gh-action-ubuntu
labels:
actions.github.com/scale-set-name: gh-action-ubuntu
actions.github.com/scale-set-namespace: ghe-action-runner
app.kubernetes.io/component: runner-set
app.kubernetes.io/instance: gh-action-ubuntu
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: gh-action-ubuntu
app.kubernetes.io/part-of: gha-runner-scale-set
app.kubernetes.io/version: 0.14.2
helm.sh/chart: gha-rs-0.14.2
Describe the expected behavior
Expecting runner runner-scale-sets created in github through gha-runner-scale-set helm chart with scaleSetLabels parameters are inserted as labels,
Additional Context
Current environment deployed with helm chart
- actions-runner-controller 0.23.7 (trying to migrate from this state)
- gha-runner-scale-set-controller-0.14.2
- gha-runner-scale-set-0.14.2
Values.yaml
runnerScaleSetName: gh-action-ubuntu
scaleSetLabels:
- ubuntu24
Relevant to
- https://github.com/actions/actions-runner-controller/pull/4408
- https://github.com/actions/actions-runner-controller/issues/3327
Controller Logs
-
Runner Pod Logs
-
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Helm chart's scaleSetLabels value and the generated EphemeralRunnerSet, then trace how the controller passes labels to the GitHub runner scale set. Reproduce the behavior with the provided values on controller and chart version 0.14.2; it is done when ubuntu24 appears as a GitHub runner-scale-set label alongside gh-action-ubuntu.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, go, helm, kubernetes
- Domain
- ci-cd, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100