actions / actions/actions-runner-controller
Client TLS certificates for AutoscalingRunnerSet
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 1.5k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 27
Description
What would you like added?
I'd like to add support for configuring client TLS certificates in AutoscalingRunnerSet
Why is this needed?
In our environment, we use an HTTPS proxy with mTLS for client authentication, e.g.
curl --proxy https://our-proxy --proxy-key $KEY_PATH --proxy-cert $CERT_PATH ...
Currently, only basic HTTP authentication is supported
Additional context
Looking at the code https://github.com/actions/actions-runner-controller/blob/088e2a3a9029f1c85e7bd3d2539f8b8ead5947f9/github/actions/client.go#L222 I think this boils down to threading configuration down to set tls.Config.GetClientCertificate
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with github/actions/client.go around the referenced client setup, then trace how AutoscalingRunnerSet configuration reaches it. Review crypto/tls.Config.GetClientCertificate and the existing proxy authentication path. Done means AutoscalingRunnerSet can configure client certificates for HTTPS proxy mTLS instead of supporting only basic authentication.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100