actions / actions/actions-runner-controller

RunnerDeployment with Resources not spinning up

Open
#2,232 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs triage
Dominant language
Go
Stars
6.5k
Forks
1.5k
Avg merge
2d 2h
Merged PRs (30d)
27

Description

Checks
Controller Version

0.22.0

Helm Chart Version

v3.8.0

CertManager Version

1.10.0

Deployment Method

Helm

cert-manager installation

Cert manager is working

Checks
  • This isn't a question or user support case (For Q&A and community support, go to Discussions. It might also be a good idea to contract with any of contributors and maintainers if your business is so critical and therefore you need priority support
  • I've read releasenotes before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
  • My actions-runner-controller version (v0.x.y) does support the feature
  • I've already upgraded ARC (including the CRDs, see charts/actions-runner-controller/docs/UPGRADING.md for details) to the latest and it didn't fix the issue
  • I've migrated to the workflow job webhook event (if you using webhook driven scaling)
Resource Definitions
Actions-runner-controller is also working with yaml file without providing resources

`apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: runners-resources
  namespace: xyz
spec:
  replicas: 2
  template:
    spec:
      organization: xyz
      labels:
        - xyz
      env:
        - name: RUNNER_FEATURE_FLAG_EPHEMERAL
          value: "true"
      image: summerwind/actions-runner-dind 
      resources:
        limits:
          cpu: "4.0"
          memory: "8Gi"
        requests:
          cpu: "2.0"
          memory: "4Gi"
---
apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  name: xyz-runners-deployment-autoscaler
  namespace: xyz
spec:
  scaleTargetRef:
    name: runners-resources
  minReplicas: 2
  maxReplicas: 5
  scaleUpTriggers:
  - githubEvent: {}
    duration: "5m"
`

`kubectl get runnerdeployment -n xyz
NAME                    DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
runners-resources   2         2         2            0           14m
`

runnerdeployment not getting ready to be use

hence runners are also in pending state.
I followed ref from this: https://github.com/actions/actions-runner-controller/blob/master/docs/automatically-scaling-runners.md
To Reproduce
create runnerdeployment.yaml
kubectl apply -f runnerdeployment.yaml
Describe the bug

when adding resources to runnerdeployment file, it didn't get ready to be used.

Describe the expected behavior

it should spin runners with provided resource definition.

Whole Controller Logs
2023-01-31T06:51:24Z	INFO	runnerdeployment	Created runnerreplicaset	{"runnerdeployment": "iss/iss-runners-resources", "runnerreplicaset": "iss-runners-resources-g5lm5"}
2023-01-31T06:51:24Z	DEBUG	runnerreplicaset	Created replica(s)	{"runnerreplicaset": "iss/iss-runners-resources-g5lm5", "lastSyncTime": null, "effectiveTime": "<nil>", "templateHashDesired": "554ff56c4f", "replicasDesired": 2, "replicasPending": 0, "replicasRunning": 0, "replicasMaybeRunning": 0, "templateHashObserved": [], "created": 2}
2023-01-31T06:51:24Z	DEBUG	runnerreplicaset	Skipped reconcilation because owner is not synced yet	{"runnerreplicaset": "iss/iss-runners-resources-g5lm5", "owner": "iss/iss-runners-resources-g5lm5-9rtrd", "pods": null}
2023-01-31T06:51:24Z	DEBUG	runnerreplicaset	Skipped reconcilation because owner is not synced yet	{"runnerreplicaset": "iss/iss-runners-resources-g5lm5", "owner": "iss/iss-runners-resources-g5lm5-9rtrd", "pods": null}
2023-01-31T06:51:24Z	DEBUG	runnerreplicaset	Skipped reconcilation because owner is not synced yet	{"runnerreplicaset": "iss/iss-runners-resources-g5lm5", "owner": "iss/iss-runners-resources-g5lm5-9rtrd", "pods": null}
2023-01-31T06:51:24Z	INFO	runner	Updated registration token	{"runner": "iss-runners-resources-g5lm5-9rtrd", "repository": ""}
2023-01-31T06:51:24Z	DEBUG	events	Successfully update registration token	{"type": "Normal", "object": {"kind":"Runner","namespace":"iss","name":"iss-runners-resources-g5lm5-9rtrd","uid":"****","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"106928238"}, "reason": "RegistrationTokenUpdated"}
2023-01-31T06:51:24Z	INFO	runner	Updated registration token	{"runner": "iss-runners-resources-g5lm5-slmd4", "repository": ""}
2023-01-31T06:51:24Z	DEBUG	runnerreplicaset	Skipped reconcilation because owner is not synced yet	{"runnerreplicaset": "iss/iss-runners-resources-g5lm5", "owner": "iss/iss-runners-resources-g5lm5-9rtrd", "pods": null}
2023-01-31T06:51:24Z	DEBUG	events	Successfully update registration token	{"type": "Normal", "object": {"kind":"Runner","namespace":"iss","name":"iss-runners-resources-g5lm5-slmd4","uid":"******","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"106928239"}, "reason": "RegistrationTokenUpdated"}
2023-01-31T06:51:24Z	INFO	runner	Created runner pod	{"runner": "iss/iss-runners-resources-g5lm5-9rtrd", "repository": ""}
2023-01-31T06:51:24Z	DEBUG	events	Created pod 'iss-runners-resources-g5lm5-9rtrd'	{"type": "Normal", "object": {"kind":"Runner","namespace":"iss","name":"iss-runners-resources-g5lm5-9rtrd","uid":"******","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"106928240"}, "reason": "PodCreated"}
2023-01-31T06:51:24Z	INFO	runner	Created runner pod	{"runner": "iss/iss-runners-resources-g5lm5-slmd4", "repository": ""}
2023-01-31T06:51:24Z	DEBUG	events	Created pod 'iss-runners-resources-g5lm5-slmd4'	{"type": "Normal", "object": {"kind":"Runner","namespace":"iss","name":"iss-runners-resources-g5lm5-slmd4","uid":"*****","apiVersion":"actions.summerwind.dev/v1alpha1","resourceVersion":"106928242"}, "reason": "PodCreated"}
Whole Runner Pod Logs
not o/p from runner logs
Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the RunnerDeployment manifest from the Resource Definitions section and inspect the pending runner pods and controller logs. Review TROUBLESHOOTING.md and automatically-scaling-runners.md for the documented resource configuration and compare the reported status and logs. Done means runners using the requested resources become ready and leave Pending state.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, helm, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.