actions / actions/actions-runner-controller
Webhooks cleanup upon Helm uninstall
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6.5k
- Forks
- 1.5k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 27
Description
What would you like added?
Cleanup of validation and mutation webhooks upon helm uninstall.
Currently it's leaving validatingwebhookconfiguration and mutatingwebhookconfiguration resources such as github-runners-validating-webhook-configuration or github-runners-mutating-webhook-configuration and in case of using and changing a custom name, these resources creates a conflict which results in failed calling webhook ... error. The workaround was documented in this issue #1558.
Why is this needed?
To make a cleanup more complete and avoid problems on changing the app name.
Additional context
Managing my infrastructure through Terraform Helm provider.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by inspecting the Helm chart's handling of validatingwebhookconfiguration and mutatingwebhookconfiguration resources during uninstall. Done means both webhook resources are removed and changing the custom application name no longer leaves conflicting resources or causes failed webhook calls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100