actions / actions/actions-runner-controller

Changes to Runner Deployments Don't Propagate

Open
#2,058 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
6.5k
Forks
1.5k
Avg merge
2d 2h
Merged PRs (30d)
27

Description

What would you like added?

A clear and concise description of what you want to happen.

When changing the RunnerDeployment, deploy new or existing runners with the changes.

Why is this needed?

Updating runner configurations requires restarting (deleting/reinstalling) the RunnerDeployment for changes to be propagated.

Additional context

For instance, if I were to add resource constrains on the docker sidecar by patching the RunnerDeployment. The existing runners are unaffected, and future runners are also unaffected.

+       dockerdContainerResources:
+         limits:
+           cpu: "2.0"
+           memory: "4Gi"
+         requests:
+           cpu: "1.0"
+           memory: "4Gi"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the RunnerDeployment reconciliation path and how updates are handled. Trace what happens after changing a RunnerDeployment, including dockerdContainerResources. Done means updated configuration propagates to existing or newly deployed runners without deleting and reinstalling the RunnerDeployment.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
ci-cd, devops, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.