actions / actions/actions-runner-controller

Make the HRA to enforce the minimum number of replicas in the RunnerDeployoment

Open
#1,886 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
6.5k
Forks
1.5k
Avg merge
2d 2h
Merged PRs (30d)
27

Description

Is your feature request related to a problem? Please describe.
In the case of HRA using webhook for scaling and reaching the max of his capacity, we can see the situation where the minimum number of replicas is not respected. That is a little bit annoying because, as a user/operator of ARC, when I define the minimum number of replicas, I expect that HRA will see that value as my desired state, and it should always force that value in the RunnerDeployment as we see in this graph

image

Describe the solution you'd like
When a RunnerDeployment reaches a number of replicas below HRA.spec.minReplicas the HRA will force the RunnerDeployment or RunnerReplicaSet to reconcile and reach a number of replicas equal to the HRA.spec.minReplicas

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the HRA reconciliation path and how it updates the RunnerDeployment or RunnerReplicaSet during webhook scaling. Reproduce the case where replicas fall below HRA.spec.minReplicas, then verify reconciliation restores the configured minimum and keeps it enforced when the HRA reaches capacity.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, go, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.