actions / actions/actions-runner-controller

Chart broken for kubernetes 1.19

Open
#1,037 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
6.5k
Forks
1.5k
Avg merge
2d 2h
Merged PRs (30d)
27

Description

For kubernetes 1.19, both extensions/v1beta1 and networking.k8s.io/v1 coexist so this approach in fact breaks this helm chart since we end up with apiVersion: extensions/v1beta1 here but also hit the {{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1" }} conditional below producing the following error:

Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.networking.v1beta1.IngressBackend
helm.go:88: [debug] error validating "": error validating data: ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "service" in io.k8s.api.networking.v1beta1.IngressBackend

Originally posted by @jsotelo in https://github.com/actions-runner-controller/actions-runner-controller/pull/988#discussion_r779635311

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Helm chart's Ingress template and inspect the apiVersion selection alongside the Capabilities.APIVersions.Has conditional mentioned in the report. Render or install the chart against Kubernetes 1.19 and verify that the generated Ingress uses fields valid for its selected API version; done means the release manifest validates successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.