aclai-lab / aclai-lab/ModalDecisionTrees.jl

Major refactoring

未关闭
#75 0 条评论 2 个 reaction 已指派 9 人 已被 @m0rr13 认领 在 GitHub 查看
help wanted
主要语言
Julia
星标
13
派生
3
PR 合并指标
30 天内没有已合并 PR

描述

Hi guys,

After a long period of minor adjustments here and there, I am now embarking on a comprehensive refactoring of this package.

I am studying the package in depth, considering four key aspects.

# Operative considerations
I am highlighting some important comments that have never been resolved, for example, by systematically moving them into docstrings (in a "!!! note" field). I am also writing almost-certainly-correct improvements (e.g., substituting `::AbstractFloat` in a signature with `::U) where {U <: ...}` .

# Educational considerations
I am writing docstrings and annotating the obscure necromancy spells that await us. (just joking, this code rocks. Wish I was good like @giopaglia!!!)

# Structural considerations
I am tidying things when I can, for example, rearranging the order of `using`/`include`/`export`s.

# Style considerations
I am conforming the style to be more Julia-like. Even if we do not follow a rigid codestyle (maybe we should), I am just changing things that are obviously strange (e.g., crazy indentations, some monocharacter variables, etc.)

I am trying to write my commit messages as clearly as possible to allow you to code things more comfortably (see the pr associated with this issue).

I already started working on a personal fork, but I am just about to push everything into this issue's branch.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。