achievements-app / achievements-app/psn-api

Wrong User Thin Trophy type returned from getUserTrophiesEarnedForTitle()

オープン
#138 コメント 2 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
TypeScript
スター
422
フォーク
56
PR マージ指標
30日以内にマージされた PR はありません

説明

Was wondering why i couldn't get the PS5 trophy progress from users and it was because the type specified was wrong. Below you can see what is actually returned with this method, instead of [User Thin Trophy](https://psn-api.achievements.app/api-docs/data-models/user-thin-trophy).

```js
{
"trophyId": 52,
"trophyHidden": true,
"earned": false,
"progress": "416", // PS5 exclusive, on trophies that have tracking
"progressRate": 89, // PS5 exclusive, on trophies that have tracking
"progressedDateTime": "2023-01-23T09:04:57Z", // PS5 exclusive, on trophies that have tracking
"trophyType": "gold",
"trophyRare": 1,
"trophyEarnedRate": "8.3"
}
```
*This is for the game Forspoken: NPWR21656_00*

I assume `User Thin Trophy` is just what gets returned from `getTitleTrophies()`, with the added `earned` and `earnedDateTime`, since I was never able to find any trophies that returned the properties `trophyProgressTargetValue`, `trophyRewardImageUrl` or `trophyRewardName`, but maybe I just didn't look on the right games.

Maybe this is Sony's PS5 exclusives only? Or are they only from `getTitleTrophies()` and unrelated to `getUserTrophiesEarnedForTitle()`?

If you are not in a hurry, you can assign me to do this PR since fixing this could be done basically at the same time I wrap up my pending PR.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。