acacode / acacode/swagger-typescript-api
header in baseApiParams has wrong type in Typescript
- Dominant language
- TypeScript
- Stars
- 4.1k
- Forks
- 436
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/acacode/swagger-typescript-api/blob/2b6db2346028fe6fb1f311bf5b1221a89837032e/templates/base/http-clients/fetch-http-client.ejs#L123-L130
according to typescript, `baseApiParams.header` is shape of `HeaderInit`.
and `type HeadersInit = [string, string][] | Record | Headers;`
and header is expand in the code above,
- expand `Headers` instance will result to `{}`
- expand `[string, string][]` will result to `{0: [string, string]}`
only `Record` will work as expected
we need to narrow `baseApiRarams.header`'s type to `Record` in `type RequestParams`
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.