abrignoni / abrignoni/iLEAPP

Media Manager - check_in_media() Limitations

Abierto
#1,530 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
1.2k
Forks
303
Merge medio
4 h 32 min
PR fusionados (30 d)
216

Descripción

I am currently working on an artifact plugin for a chat app. I am trying to avoid having too permissive of a regex path search (in my case: /private/var/mobile/Containers/Shared/AppGroup/{GUID}/Attachments/{FILES}). I figured I would use `Context.seeker.search()` to get my attachments so I could avoid bringing in every app that has an Attachments folder. The problem is `check_in_media()` cannot be used with files that are not found as part of the initial regex path search in the artifact header dict. Any files found manually by calling `seeker.search()` don't get added to the Context's `_files_found` or `_filename_lookup_map`. `check_in_media()` and `_check_in_media()` both use: `Context.get_source_file_path({path})`.

I created a new static method in Context.py that I can pass the results from `seeker.search()` into for testing, which allowed me to make use of `check_in_media()` and my artifact results appear as expected in the table view and conversation view (LAVA).
```
@staticmethod
def add_files_to_context(new_files):
if not isinstance(new_files, list):
new_files = [new_files]

Context._files_found.extend(new_files)
Context._filename_lookup_map = {}
```

I don't know the best way to tackle this problem. I'm not sure if adding something to the Context is best, some change to the Media Manager would be better, or if I'm missing some other existing way to handle this.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.