abpframework / abpframework/abp

Extract Toolbar system

Open
#7,904 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

abp-framework discussion
Dominant language
C#
Stars
14.4k
Forks
3.7k
Avg merge
15h 32m
Merged PRs (30d)
106

Description

BlazorUI Toolbar system just repeats the code of the MVC UI Toolbar system.

Maybe we can extract them. like Volo.Abp.UI.ToolBars. @hikalkan what do you think?

https://github.com/abpframework/abp/tree/dev/framework/src/Volo.Abp.AspNetCore.Components.WebAssembly.Theming/Toolbars

https://github.com/abpframework/abp/tree/dev/framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Toolbars

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the toolbar implementations in framework/src/Volo.Abp.AspNetCore.Components.WebAssembly.Theming/Toolbars and framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Toolbars. Review the existing Volo.Abp.UI.ToolBars area as the possible shared location. Done means the duplicated BlazorUI and MVC toolbar code is extracted into a shared system and both implementations use it.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.