abpframework / abpframework/abp

Can sort by fields which are not defined in DTO

Open
#2,732 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

abp-framework feature
Dominant language
C#
Stars
14.4k
Forks
3.7k
Avg merge
15h 32m
Merged PRs (30d)
106

Description

You can order by fields in CrudAppService even if they are not defined in the DTO. I am not sure if this is meant to be like that.

Related code:

https://github.com/abpframework/abp/blob/0a1568781df03fe9c86dc38cb7d47b95389cdf0b/framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/CrudAppService.cs#L188

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at framework/src/Volo.Abp.Ddd.Application/Volo/Abp/Application/Services/CrudAppService.cs around line 188 and trace how ordering fields are accepted. The issue does not establish whether ordering by fields outside the DTO is intended; confirm that behavior with maintainers before defining the change and its completion criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.