abpframework / abpframework/abp
Query string friendly PagerModel
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 14.4k
- Forks
- 3.7k
- Avg merge
- 15h 32m
- Merged PRs (30d)
- 106
Description
ABP 5.1.3 (MVC)
For example i have an index page to list some books and it has books filtering (genre, author, release date, etc) system. When user filter books by genre, it will append genre query string so the url will become example.com/books?genre=fantasy. Then user navigate to page 2 and url become example.com/books?genre=fantasy¤tPage=2.
Right now i'm using HttpContext.Request.GetEncodedPathAndQuery() as PagerModel's pageUrl, so when user navigate again to page 3, it will append another currentPage instead of replacing currentPage value and the url will become example.com/books?genre=fantasy¤tPage=2¤tPage=3.
I hope you understand, it's hard to explain for me because im not native english speaker.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating PagerModel and the use of HttpContext.Request.GetEncodedPathAndQuery(). Reproduce pagination with an existing filter query, then verify that moving between pages replaces currentPage while preserving the other query parameters. Done means generated page links contain only one currentPage value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100