aboutcode-org / aboutcode-org/vulnerablecode

fix: Replace bare [except] with explicit `Exception` in pipes/advisory.py

Open
#2,074 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
702
Forks
328
Avg merge
3d 8h
Merged PRs (30d)
3

Description

## Summary

The file [vulnerabilities/pipes/advisory.py] contains a bare `except:` clause at line 459 which violates PEP 8 (E722) and can lead to unexpected behavior.

## Problem

Bare `except:` clauses catch **all** exceptions, including:
- `SystemExit` - prevents clean program termination
- `KeyboardInterrupt` - prevents Ctrl+C from working
- `GeneratorExit` - can break generator cleanup

## Location

**File:** [vulnerabilities/pipes/advisory.py]
**Line:** 459
**Current code:**
```python
except:
if logger:
logger(
f"Failed to create VulnerabilitySeverity for: {severity} with error:\n{traceback_format_exc()}",
level=logging.ERROR,
)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.