aboutcode-org / aboutcode-org/scancode-toolkit

Detection finds `google-patent-license-golang` in Polymer license text

Open
#3,907 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
2.6k
Forks
791
Avg merge
1d 12h
Merged PRs (30d)
5

Description

The license text found in plenty of NPM packages, e.g. [^1], is detected as `BSD-3-Clause AND LicenseRef-scancode-google-patent-license-golang`. This is wrong, because the actual license text is `google-patent-license` plus some polymer specific header, while `google-patent-license-golang = google-patent-license + some Golang specific header`.

ScanCode has the following variations of the google patent license,
whereas licenses IDs with a suffix after `google-patent-license` contain `google-patent-license` plus some header:
- https://scancode-licensedb.aboutcode.org/google-patent-license-fuchsia.html
- https://scancode-licensedb.aboutcode.org/google-patent-license-golang.html
- https://scancode-licensedb.aboutcode.org/google-patent-license-webm.html
- https://scancode-licensedb.aboutcode.org/google-patent-license-webrtc.html
- https://scancode-licensedb.aboutcode.org/google-patent-license.html

Proposed solution:
- preferred: Add a new license ID: `google-patent-license-polymer`
- alternative: Change the detection to detect `BSD-3-Clause AND LicenseRef-scancode-google-patent-license`.

[^1]: https://github.com/PolymerElements/iron-a11y-keys-behavior/blob/ebfffaf7bd630ba43b7cff143d5c25d5e55e14bd/iron-a11y-keys-behavior.js#L2-L9

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.