aboutcode-org / aboutcode-org/scancode-toolkit

False positive detecton of proprietary-license from proprietary-license_276.RULE

Open
#3,355 1 comment 0 reactions 1 assignee Claimed by @AyanSinhaMahapatra View on GitHub
bug license-review
Dominant language
Python
Stars
2.6k
Forks
791
Avg merge
1d 12h
Merged PRs (30d)
5

Description

Recent scans of pdfbox-2.0.24-sources.jar and pdfbox-2.0.24.jar returned a detection of proprietary-license from files DecodeOptions.java and DecodeOptions$FinalDecodeOptions.class on the string "may not be modified" which triggered the proprietary-license_276.RULE

That detection is much too aggressive, because in the context of the code, it was simply the generation of an error message (possibly when someone/something is trying to change a pdf). Here is one case in the code:

`throw new UnsupportedOperationException(“This instance may not be modified.“)`

I am not exactly sure what the approach should be to address this, but I think it generally means that finding "may not be modified" probably means proprietary only in the context of a Notice file or code Comments, but it should not be triggered when that text appears in actual code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.